fix: extract sdkSessionId when reading from logs#190
Merged
jonathanlab merged 1 commit intomainfrom Dec 3, 2025
Merged
Conversation
joshsny
reviewed
Dec 3, 2025
| notifications.push(stored.notification.params as SessionNotification); | ||
| } | ||
|
|
||
| // Extract SDK session ID from _posthog/sdk_session notification |
Contributor
There was a problem hiding this comment.
Why do we need to do this, isn't session id = task run id?
Contributor
Author
There was a problem hiding this comment.
We have 4 IDs:
Task ID
Task run ID
ACP Session ID
Agent (Claude/Codex/Gemini) SDK ID (This stores context remotely, and is being retrieved in this PR)
We retrieve the logs using Task ID + Task Run ID.
The ACP Session ID is always equivalent to the task run ID.
The Agent SDKs return their own ID once a conversation is created. We store that via _posthog/sdk_session in the log, and retrieve it on session resumption. This ID is used by the provider to store context etc.See also: https://platform.claude.com/docs/en/agent-sdk/sessions
joshsny
approved these changes
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we werent reading sdkSessionId from the logs anymore, which caused claude to lose context on session restore. this makes sure we extract it from the logs